Update footer to have grid sections #628
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@kjaymiller Created a draft PR. Just need the phone number and address for this PR to be closed |
Contributor
Is there a reason we're providing the phone number and address? If so, I plan to give you GNOME's information as I would prefer not to share my personal information. |
Contributor
Author
|
no specific reason. I'll just take out that section then and stick to only social media contacts |
….github.io into update-footer-to-have-grid-sections
kjaymiller
reviewed
Jan 9, 2025
kjaymiller
requested changes
Jan 9, 2025
Contributor
kjaymiller
left a comment
kjaymiller
left a comment
There was a problem hiding this comment.
There is one change and one comment. if you can fix the change and address the comment (no need to completely rewrite the css on this one)
Co-authored-by: Jay Miller <kjaymiller@gmail.com>
kjaymiller
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Link 🔗:
Issue: #470
Type of Change
Description 📋
Changed the footer section from list to a grid style
Checklist ✅
pre-commit run --allAdditional Notes & Screenshots